inference/unify output buffer management #11569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyx0718
reviewed
Jun 20, 2018
|
|
||
| namespace paddle { | ||
|
|
||
| PaddleBuf::PaddleBuf(PaddleBuf&& other) |
There was a problem hiding this comment.
| Free(); | ||
| data_ = new char[length]; | ||
| length_ = length; | ||
| memory_owned_ = true; |
There was a problem hiding this comment.
reset a new length.
There was a problem hiding this comment.
I mean memory_owned_ is already true, as assert before.
| std::memcpy( | ||
| outputs->at(i).data.data, data.data(), outputs->at(i).data.length); | ||
| auto &buffer = outputs->at(i).data; | ||
| if (buffer.empty() || buffer.length() < sizeof(float) * data.size()) { |
There was a problem hiding this comment.
Maybe we don't want to allow buffer.length() > sizeof(float) * data.size()? If that's the case, how does client know how many bytes to use?
There was a problem hiding this comment.
It is safe to Resize here.
If the client doesn't know how much to allocate or Resize, just init with a large enough memory, and do not resize it.
| // Only the owned memory can be reset, the external memory can't be changed. | ||
| assert(memory_owned_); | ||
| Free(); | ||
| data_ = new char[length]; |
There was a problem hiding this comment.
If the length == length_, can return early?
panyx0718
approved these changes
Jun 20, 2018
| Free(); | ||
| data_ = new char[length]; | ||
| length_ = length; | ||
| memory_owned_ = true; |
There was a problem hiding this comment.
I mean memory_owned_ is already true, as assert before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaddleBufpossible to manage the buffer