Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify datanorm op test=develop #23030

Merged
merged 24 commits into from
Apr 14, 2020

Conversation

yaoxuefeng6
Copy link
Contributor

@yaoxuefeng6 yaoxuefeng6 commented Mar 16, 2020

Add enable_scale_and_shift option in datanorm op
By setting enable_scale_and_shift, this op will do scale and shift after normalization like batchnorm.

@xjqbest xjqbest self-requested a review April 12, 2020 15:23
xjqbest
xjqbest previously approved these changes Apr 12, 2020
Copy link
Contributor

@xjqbest xjqbest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

saxon-zh
saxon-zh previously approved these changes Apr 13, 2020
@@ -53,7 +53,9 @@ const std::unordered_set<std::string> op_has_unsed_vars_white_list = {
"precision_recall", // 1
"fusion_seqpool_cvm_concat", // 2
"fused_batch_norm_act", // 2
"fused_batch_norm_act_grad" // 2
"fused_batch_norm_act_grad", // 2
"data_norm",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments to specify the type, like other op.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@yaoxuefeng6 yaoxuefeng6 dismissed stale reviews from saxon-zh and xjqbest via 889ce00 April 13, 2020 04:57
@zhiqiu zhiqiu self-requested a review April 13, 2020 06:41
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for unused_var_check.cc

@yaoxuefeng6 yaoxuefeng6 requested a review from fuyinno4 April 13, 2020 09:01
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaoxuefeng6 yaoxuefeng6 merged commit 5b69242 into PaddlePaddle:develop Apr 14, 2020
Thunderbrook pushed a commit to Thunderbrook/Paddle that referenced this pull request Aug 7, 2020
Thunderbrook pushed a commit to Thunderbrook/Paddle that referenced this pull request Aug 7, 2020
Thunderbrook added a commit that referenced this pull request Aug 12, 2020
…atanorm op (#26046)

* fix dataset py3 (#25012)

* fix dataset py3 error
* test=develop

* fix logger (#24682)

* fix logger of FetchHandler,which may print log twice
* test=develop

* add timeout and http store in communication (#23436)

* add timeout and http store in communication, add revert and confirm in fleet
* test=develop

* modify datanorm op test=develop (#23030)

Co-authored-by: xujiaqi01 <173596896@qq.com>
Co-authored-by: yaoxuefeng <yaoxuefeng@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants