Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPs] Bug fix, fix the segment mean for illegal syncthreads usage. #32596

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Apr 26, 2021

PR types

Bug fixes

PR changes

OPs

Describe

The syncthreads only sync in block. However there should be global sync in the cuda kernel.
So, we fixed it by launch two kernels.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_ENFORCE

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 1afe1ac into PaddlePaddle:develop Apr 27, 2021
ZHUI added a commit to ZHUI/Paddle that referenced this pull request Apr 27, 2021
…addlePaddle#32596)

* [OPs] Bug fix, fix the segment mean for illegal syncthreads usage.
XiaoguangHu01 pushed a commit that referenced this pull request Apr 27, 2021
…32596) (#32610)

* [OPs] Bug fix, fix the segment mean for illegal syncthreads usage.
XiaoguangHu01 pushed a commit that referenced this pull request May 7, 2021
* [OPs] Bug fix, fix the segment mean for illegal syncthreads usage. (#32596) (#32610)

* [OPs] Bug fix, fix the segment mean for illegal syncthreads usage.

* remove packages in __all__

* create new public api level paddle.callbacks;paddle.hub;paddle.utils.unique_name

Co-authored-by: Zhong Hui <zhonghui.net@gmail.com>
@ZHUI ZHUI deleted the op/segment_debug branch August 29, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants