Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raw program meta optimizer #32597

Merged
merged 9 commits into from
May 8, 2021
Merged

Add raw program meta optimizer #32597

merged 9 commits into from
May 8, 2021

Conversation

sandyhouse
Copy link

@sandyhouse sandyhouse commented Apr 26, 2021 •
edited
Loading

PR types

New features

PR changes

Others

Describe

Add raw program meta optimizer which run executor (Executor) using program other than parallel executor (PE)

How to use:

import paddle.distributed.fleet as fleet

strategy = fleet.DistributedStrategy()
strategy.without_graph_optimization = True

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 27, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 27, 2021
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 27, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 27, 2021
@sandyhouse sandyhouse requested a review from wangxicoding May 6, 2021 03:28
@sandyhouse sandyhouse closed this May 6, 2021
@sandyhouse sandyhouse reopened this May 6, 2021
wangxicoding
wangxicoding reviewed May 7, 2021
View reviewed changes
python/paddle/distributed/fleet/meta_optimizers/raw_program_optimizer.py
continue

block.append_op(
type='c_broadcast',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前面没有 wait calc stream

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方不需要添加，原因是c_broadcast操作添加在通信组创建之后，前面的计算操作均已经完成。

@sandyhouse sandyhouse requested a review from wangxicoding May 7, 2021 11:43
wangxicoding
wangxicoding approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyhouse sandyhouse merged commit c1c18b0 into PaddlePaddle:develop May 8, 2021
sandyhouse pushed a commit to sandyhouse/Paddle that referenced this pull request Jun 10, 2021
Add raw program meta optimizer (PaddlePaddle#32597)
a806500 
* add raw program, test=develop
fuyinno4 pushed a commit that referenced this pull request Jun 16, 2021
@FeixLiu @youth123
[CP] add a strategy to run program with fleet (#33511)
bb5963d 
* Add raw program meta optimizer (#32597)

* add raw program, test=develop

* add precision unitest for executor all reduce (#33339)

* fix dp (#33297)

Co-authored-by: Yuang Liu <liuyuang@baidu.com>
Co-authored-by: 李季 <2042519524@qq.com>
@sandyhouse sandyhouse deleted the add_without_graph_optimizer branch March 8, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxicoding wangxicoding wangxicoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandyhouse @wangxicoding