Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDNN] bump up oneDNN to 2.2.2 #32685

Merged
merged 2 commits into from
May 24, 2021
Merged

Conversation

jczaja
Copy link
Contributor

@jczaja jczaja commented Apr 29, 2021

PR types

Bug fixes

PR changes

Others

Describe

This is an update of oneDNN to 2.2.2 it contains some optimizations that should help to some of performance drops reported at (#32311).

@jczaja jczaja requested a review from lidanqing-intel April 29, 2021 09:32
@jczaja jczaja added the Intel label Apr 29, 2021
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase self-requested a review April 29, 2021 15:00
jakpiase
jakpiase previously approved these changes Apr 29, 2021
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luotao1
luotao1 previously approved these changes Apr 30, 2021
@luotao1
Copy link
Contributor

luotao1 commented Apr 30, 2021

@jczaja If this PR could be merged, please tell me

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 7, 2021

Sorry to inform you that 0ec9d4a's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@lidanqing-intel
Copy link
Contributor

Hi, I am tesing ICX for PDT review and for Li Wei. I will provide oneDNN team logs after I finish current work

@jczaja jczaja closed this May 20, 2021
@jczaja jczaja reopened this May 20, 2021
@lidanqing-intel
Copy link
Contributor

I tested on my i9 machine, and it is around 2% perf rise. We should merge it. Thanks!
LGTM.
@luotao1

@jczaja jczaja dismissed stale reviews from luotao1 and jakpiase via 7b01e08 May 21, 2021 15:19
@jczaja jczaja changed the title [still testing][oneDNN] bump up oneDNN to 2.2.2 [oneDNN] bump up oneDNN to 2.2.2 May 21, 2021
@jakpiase jakpiase self-requested a review May 21, 2021 15:21
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit b8e4ec7 into PaddlePaddle:develop May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants