Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Windows CI and open the normal GPU unittest on CI #32794

Merged
merged 3 commits into from
May 12, 2021

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented May 7, 2021

PR types

Others

PR changes

Others

Describe

Polish windows CI:

  1. Remove some unittest that is frequent to fail in parallel_UT_rule.py .

  2. Clear build directory every day to reduce risk, because different PR use a same build directory may result in problem, such as:
    image

  3. Open about 40 GPU unittest that has been fixed and is normal, which will increase about 10 min unittest time. But it is still necessary.

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 7, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhwesky2010 zhwesky2010 changed the title fix windows CI Polish windows CI May 7, 2021
@zhwesky2010 zhwesky2010 changed the title Polish windows CI Polish Windows CI May 8, 2021
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for opening the normal GPU unittest on CI

@zhwesky2010 zhwesky2010 requested review from XieYunshen and luotao1 May 12, 2021 12:15
set(CMAKE_CXX_FLAGS_DEBUG "/Zi /DEBUG")
set(CMAKE_CXX_FLAGS_RELEASE "/O2 /DNDEBUG")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "/O2 /DNDEBUG")
set(CMAKE_CXX_FLAGS_MINSIZEREL "/Os /DNDEBUG")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些编译参数必须显示指定吗?

Copy link
Contributor

@Avin0323 Avin0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit eeca963 into PaddlePaddle:develop May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants