-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish Windows CI and open the normal GPU unittest on CI #32794
Polish Windows CI and open the normal GPU unittest on CI #32794
Conversation
Thanks for your contribution! |
9f39206
to
103a5d7
Compare
103a5d7
to
29a460c
Compare
29a460c
to
6eef07e
Compare
6eef07e
to
51c72b9
Compare
51c72b9
to
bed957e
Compare
bed957e
to
b5ed650
Compare
b5ed650
to
c38d641
Compare
c38d641
to
78125ea
Compare
78125ea
to
8a1b48f
Compare
8a1b48f
to
3240f1a
Compare
3240f1a
to
32e2276
Compare
32e2276
to
b24d233
Compare
36f1f47
to
3fe123f
Compare
3fe123f
to
9bebf3a
Compare
9bebf3a
to
3ce6b1a
Compare
3ce6b1a
to
65e38a8
Compare
65e38a8
to
6f4100c
Compare
6f4100c
to
5b9dad2
Compare
5b9dad2
to
095ad30
Compare
095ad30
to
43cd8ef
Compare
43cd8ef
to
adb8aea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for opening the normal GPU unittest on CI
set(CMAKE_CXX_FLAGS_DEBUG "/Zi /DEBUG") | ||
set(CMAKE_CXX_FLAGS_RELEASE "/O2 /DNDEBUG") | ||
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "/O2 /DNDEBUG") | ||
set(CMAKE_CXX_FLAGS_MINSIZEREL "/Os /DNDEBUG") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些编译参数必须显示指定吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe
Polish windows CI:
Remove some unittest that is frequent to fail in
parallel_UT_rule.py
.Clear build directory every day to reduce risk, because different PR use a same build directory may result in problem, such as:

Open about 40 GPU unittest that has been fixed and is normal, which will increase about 10 min unittest time. But it is still necessary.