Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make check_op_desc.py support python3 #32807

Merged
merged 1 commit into from
May 10, 2021
Merged

make check_op_desc.py support python3 #32807

merged 1 commit into from
May 10, 2021

Conversation

tianshuo78520a
Copy link
Collaborator

@tianshuo78520a tianshuo78520a commented May 9, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

cmp 方法在python3.4中取消，使用operator来代替

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 9, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Shixiaowei02 Shixiaowei02 requested a review from liym27 May 10, 2021 03:11
luotao1
luotao1 approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Superjomn
Superjomn approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn changed the title fix python3 make check_op_desc.py support python3 May 10, 2021
@Superjomn Superjomn merged commit 92adece into PaddlePaddle:develop May 10, 2021
@tianshuo78520a tianshuo78520a mentioned this pull request May 10, 2021
Merged
luotao1 pushed a commit that referenced this pull request May 10, 2021
@tianshuo78520a
Revert "make check_op_desc.py support python3 (#32807)" (#32818)
5fc734c 
This reverts commit 92adece.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superjomn Superjomn Superjomn approved these changes

@luotao1 luotao1 luotao1 approved these changes

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

@liym27 liym27 Awaiting requested review from liym27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tianshuo78520a @Superjomn @luotao1 @Shixiaowei02