Support new API linalg.cond in paddle #35140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
TCChenlong
reviewed
Sep 14, 2021
| from .tensor.linalg import matrix_power # noqa: F401 | ||
| from .tensor import inverse as inv # noqa: F401 | ||
| from .tensor.linalg import svd | ||
|
|
||
| __all__ = [ | ||
| 'cholesky', #noqa | ||
| 'norm', | ||
| 'cond', |
There was a problem hiding this comment.
这里应该和 paddle/init.py 里的 96&496行冲突了，不能同时在两个 all 中
There was a problem hiding this comment.
1个API可以有多个别名，但是开放的推荐位置是设计时就唯一确定，比如这个API开放的推荐位置是 paddle.linalg.cond，则其只能加入到相应位置(这里为python/paddle/linalg.py中)的 all 列表中，不能加入到其它的__all__ 列表。
There was a problem hiding this comment.
好的，已在python/paddle/init.py中的__all__列表中将'cond'删去了。
python/paddle/tensor/linalg.py
Outdated
| import paddle | ||
| import numpy as np | ||
| np_input = [[1., 0, -1], [0, 1, 0], [1, 0, 1]] | ||
| x = paddle.to_tensor(np_input) |
There was a problem hiding this comment.
567 -> 569 直接改为 x = paddle.to_tensor([[1., 0, -1], [0, 1, 0], [1, 0, 1]]) 即可
jeff41404
reviewed
Sep 15, 2021
python/paddle/__init__.py
Outdated
| @@ -492,6 +493,7 @@ | |||
| 'expand_as', | |||
| 'stack', | |||
| 'sqrt', | |||
| 'cond', | |||
There was a problem hiding this comment.
这里不推荐加入到__all__列表，推荐加入到 python/paddle/linalg.py中的__all__列表，原因在下面解释
lanxianghit
approved these changes
Sep 16, 2021
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* Support new API linalg.cond in paddle * check code style * check code style * modify codes * add docs_eng of linalg.cond * add svd_norm for linalg.cond * modify docs_en of cond * add support for empty input in dynamic mode * modify set_time of unittest * update * modify unittest of cond * update * remove cond in paddle.__all__ * pull latest codes * merge latest codes * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Support new API 'paddle.linalg.cond' in static/dynamic mode, which can be also called by 'paddle.cond'.
Its doc PR in Chinese is available at PR-3849
docs_cn：
Example :