Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify gc logic, use new device_event #35208

Merged
merged 8 commits into from
Sep 3, 2021
Merged

modify gc logic, use new device_event #35208

merged 8 commits into from
Sep 3, 2021

Conversation

wanghuancoder
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

修改GC逻辑。

  • 去掉不必要的宏开关
  • CUDA Event初始化使用cudaEventDisableTiming
  • event->Query()失败后,使用sched_yield尝试让出线程权限

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gc_queue_->AddTask(
[ container = garbages_.release(), event = &gc_event_[instr_id] ]() {
while (!event->Query()) {
#if defined(_WIN32)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我们可以封装一层函数么?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢!后续优化!

@wanghuancoder wanghuancoder merged commit 80c0cc9 into PaddlePaddle:develop Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants