[Dy2Stat]Polish for zip in dy2stat #37846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
added 2 commits
December 6, 2021 02:18
Aurelius84
reviewed
Dec 6, 2021
| """ | ||
| assert isinstance(node, gast.Call) | ||
| if is_paddle_api(node): | ||
| return True | ||
|
|
||
| func_str = ast_to_source_code(node.func).strip() | ||
| try: | ||
| from paddle.fluid.dygraph.dygraph_to_static.convert_call_func import is_builtin_len, is_builtin | ||
| from paddle.fluid.dygraph.dygraph_to_static.convert_call_func import is_builtin_len, is_builtin, is_builtin_zip |
There was a problem hiding this comment.
We should avoid Runtime import, please put it ahead of the file.
There was a problem hiding this comment.
这里应该会有循环import的问题，放在前面会报错
| def is_builtin_zip(func): | ||
| if is_builtin(func) and func.__name__ == 'zip': | ||
| return True | ||
| return False |
There was a problem hiding this comment.
return is_builtin(func) and func.__name__ == 'zip'
| if isinstance(arg, Variable) and arg.shape[0] == -1: | ||
| raise ValueError( | ||
| "If the parameter is Variable in 'zip', its first dimension should not be -1. " | ||
| "But args[{}].shape[0] == -1 in 'zip'".format(str(i))) |
There was a problem hiding this comment.
Suggested change
| "But args[{}].shape[0] == -1 in 'zip'".format(str(i))) | |
| Not support zip(tensor, ...) when tensor.shape[0] == -1, but found args[{}].shape[0] == -1 in 'zip' |
| def convert_zip(*args): | ||
| for i, arg in enumerate(args): | ||
| if isinstance(arg, Variable) and arg.shape[0] == -1: | ||
| raise ValueError( |
Aurelius84
approved these changes
Dec 7, 2021
0x45f
added a commit
to 0x45f/Paddle
that referenced
this pull request
Dec 7, 2021
* polish for zip in dy2stat * polish comment * polish is_builtin_len * fix comment
lanxianghit
pushed a commit
that referenced
this pull request
Dec 9, 2021
Zjq9409
pushed a commit
to Zjq9409/Paddle
that referenced
this pull request
Dec 10, 2021
* polish for zip in dy2stat * polish comment * polish is_builtin_len * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
polish for zip in dy2stat