fix bugs: output of splited fc is wrong #38724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wangxicoding
approved these changes
Jan 6, 2022
| @@ -1219,6 +1219,7 @@ def _parallel_linear(x, | |||
| inputs={'X': linear_out}, | |||
| outputs={'Out': out}, | |||
| attrs={ | |||
| 'rank': inner_rank, | |||
There was a problem hiding this comment.
之后在c++端给c_concat的rank参数默认设为-1，这样在c++端就可以立马检测出python端没有设置rank了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
在distributed.collective._parallel_linear 中
c_concat 的没有加入rank参数，导致反向时调用c_split时不能判断当前rank
因此总是按照rank默认值（0）输出，导致结果不正确