【Hackathon 33】Modified the case where Tensor cannot be used on DCU #41695

ImNoBadBoy · 2022-04-12T07:47:42Z

PR types

【Hackathon 33 曙光算子修复】PR提交
#40300

PR changes

修改了四个文件
test_trunc_op.py
test_where_op.py
test_yolo_box_op.py
test_zeros_like_op.py

Describe

test_trunc_op.py

vim /public/home/acv2h3zdq0/Paddle/build/python/paddle/fluid/tests/unittests/test_trunc_op.py
42 self.check_output()
45 self.check_grad(['X'], 'Out', numeric_grad_delta=1e-5)

test_where_op.py

vim /public/home/acv2h3zdq0/Paddle/build/python/paddle/fluid/tests/unittests/test_where_op.py
251 assert np.array_equal(out.cpu().numpy(), np.where(cond_i, x_i, y_i))
269 result = result.cpu().numpy()
270 expect = np.where(cond.cpu(), a.cpu(), b.cpu())

test_yolo_box_op.py
没有修改直接测试通过

test_zeros_like_op.py

vim /public/home/acv2h3zdq0/Paddle/build/python/paddle/fluid/tests/unittests/test_zeros_like_op.py

73 if core.is_compiled_with_cuda():
74 self.assertEqual((out.cpu().numpy() == np.zeros(shape, dtype)).all(),True)
75 else:
76 self.assertEqual((out.numpy() == np.zeros(shape, dtype)).all(),True)

78 if core.is_compiled_with_cuda():
79 self.assertEqual((out.cpu().numpy() == np.zeros(shape, dtype)).all(), True)
80 else:
81 self.assertEqual((out.numpy() == np.zeros(shape, dtype)).all(), True)

83 if core.is_compiled_with_cuda():
84 self.assertEqual((out.cpu().numpy() == np.zeros(shape, dtype)).all(), True)
85 else:
86 self.assertEqual((out.numpy() == np.zeros(shape, dtype)).all(), True)
87 paddle.enable_static()

CLAassistant · 2022-04-12T07:47:50Z

All committers have signed the CLA.

paddle-bot-old · 2022-04-12T07:49:01Z

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

paddle-bot-old · 2022-04-12T07:49:33Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

ronny1996 · 2022-04-18T03:12:52Z

python/paddle/fluid/tests/unittests/test_trunc_op.py

@@ -1,4 +1,4 @@
-#   Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.
+#   Copyright (c) 021 PaddlePaddle Authors. All Rights Reserved.


这里不需要修改

ronny1996 · 2022-04-18T03:22:02Z

python/paddle/fluid/tests/unittests/test_trunc_op.py

+
+if __name__ == "__main__":
+    unittest.main()
+m __future__ import print_function


请检查一下这里多出的重复代码

ronny1996 · 2022-04-18T03:23:03Z

python/paddle/fluid/tests/unittests/test_trunc_op.py

+
+
+
+import unittest


请检查这里多出的代码，另外请使用pre-commit工具在提交PR前检查一下

已经删除了

ronny1996 · 2022-04-18T03:24:23Z

python/paddle/fluid/tests/unittests/test_where_op.py

@@ -248,7 +248,7 @@ def test_api(self):
            y = fluid.dygraph.to_variable(y_i)
            cond = fluid.dygraph.to_variable(cond_i)
            out = paddle.where(cond, x, y)
-            assert np.array_equal(out.numpy(), np.where(cond_i, x_i, y_i))
+            assert np.array_equal(out.cpu().numpy(), np.where(cond_i, x_i, y_i))


这里直接.numpy()不行吗？

cuda上的数据不能直接使用.numpy()获取数据值

cuda上的数据应该能拷贝到cpu再转成numpy，这个测试过吗？如果不可以，我再确认下

对的，我们单测通过了

ronny1996 · 2022-04-18T03:24:59Z

python/paddle/fluid/tests/unittests/test_zeros_like_op.py

-            self.assertEqual((out.numpy() == np.zeros(shape, dtype)).all(),
-                             True)
+            if core.is_compiled_with_cuda():
+                self.assertEqual((out.cpu().numpy() == np.zeros(shape, dtype)).all(),True)


这里直接.numpy()不行吗？

cuda上的数据不能直接使用.numpy()获取数据值

cuda上的数据应该能拷贝到cpu再转成numpy，这个测试过吗？如果不可以，我再确认下

TCChenlong · 2022-04-25T01:59:26Z

@ImNoBadBoy 可以根据 review 意见修改下~

修改第一行同原先本部一样

1

对无关代码进行删除

ImNoBadBoy

对代码进行了修改，把重复代码进行了删除

ImNoBadBoy

您好已经按照您的要求进行了修改

ImNoBadBoy · 2022-04-25T13:13:25Z

python/paddle/fluid/tests/unittests/test_where_op.py

@@ -248,7 +248,7 @@ def test_api(self):
            y = fluid.dygraph.to_variable(y_i)
            cond = fluid.dygraph.to_variable(cond_i)
            out = paddle.where(cond, x, y)
-            assert np.array_equal(out.numpy(), np.where(cond_i, x_i, y_i))
+            assert np.array_equal(out.cpu().numpy(), np.where(cond_i, x_i, y_i))


cuda上的数据不能直接使用.numpy()获取数据值

ronny1996

cuda上的数据应该能拷贝到cpu再转成numpy，这个测试过吗？如果不可以，我再确认下

ronny1996 · 2022-04-26T07:56:58Z

python/paddle/fluid/tests/unittests/test_zeros_like_op.py

-            self.assertEqual((out.numpy() == np.zeros(shape, dtype)).all(),
-                             True)
+            if core.is_compiled_with_cuda():
+                self.assertEqual((out.cpu().numpy() == np.zeros(shape, dtype)).all(),True)


cuda上的数据应该能拷贝到cpu再转成numpy，这个测试过吗？如果不可以，我再确认下

ronny1996 · 2022-04-26T07:57:07Z

python/paddle/fluid/tests/unittests/test_where_op.py

@@ -248,7 +248,7 @@ def test_api(self):
            y = fluid.dygraph.to_variable(y_i)
            cond = fluid.dygraph.to_variable(cond_i)
            out = paddle.where(cond, x, y)
-            assert np.array_equal(out.numpy(), np.where(cond_i, x_i, y_i))
+            assert np.array_equal(out.cpu().numpy(), np.where(cond_i, x_i, y_i))


cuda上的数据应该能拷贝到cpu再转成numpy，这个测试过吗？如果不可以，我再确认下

paddle-bot-old · 2022-05-03T02:55:55Z

Sorry to inform you that 1c7b152's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

paddle-bot · 2023-08-29T06:35:25Z

Since you haven't replied for more than a year, we have closed this issue/pr.
If the problem is not solved or there is a follow-up one, please reopen it at any time and we will continue to follow up.
由于您超过一年未回复，我们将关闭这个issue/pr。
若问题未解决或有后续问题，请随时重新打开，我们会继续跟进。

Modified the case where Tensor cannot be used on DCU

89de6ee

paddle-bot-old bot added contributor External developers status: proposed labels Apr 12, 2022

This was referenced Apr 12, 2022

【PaddlePaddle Hackathon 2】33、为Paddle修复ROCM(HIP)算子 #40300

Closed

【PaddlePaddle Hackathon 第二期】任务总览 #40234

Closed

【Hackathon 33 曙光算子修复】PR提交 #41624

Closed

PaddlePaddle locked and limited conversation to collaborators Apr 18, 2022

PaddlePaddle unlocked this conversation Apr 18, 2022

ronny1996 reviewed Apr 18, 2022

View reviewed changes

ImNoBadBoy added 3 commits April 25, 2022 11:44

Update test_trunc_op.py

6153068

修改第一行同原先本部一样

Merge pull request #1 from PaddlePaddle/develop

1fb7b95

1

Update test_trunc_op.py

1c7b152

对无关代码进行删除

ImNoBadBoy commented Apr 25, 2022

View reviewed changes

ronny1996 requested changes Apr 26, 2022

View reviewed changes

luotao1 added the PaddlePaddle Hackathon label Aug 5, 2022

paddle-bot bot removed the status: proposed label Aug 5, 2022

paddle-bot bot closed this Aug 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 33】Modified the case where Tensor cannot be used on DCU #41695

【Hackathon 33】Modified the case where Tensor cannot be used on DCU #41695

ImNoBadBoy commented Apr 12, 2022 •

edited

Loading

CLAassistant commented Apr 12, 2022 •

edited

Loading

paddle-bot-old bot commented Apr 12, 2022

paddle-bot-old bot commented Apr 12, 2022

ronny1996 Apr 18, 2022

ronny1996 Apr 18, 2022

ronny1996 Apr 18, 2022

ImNoBadBoy Apr 25, 2022

ronny1996 Apr 18, 2022

ImNoBadBoy Apr 25, 2022

ronny1996 Apr 26, 2022

ImNoBadBoy Apr 29, 2022

ronny1996 Apr 18, 2022

wangjincheng123456 Apr 24, 2022

ronny1996 Apr 26, 2022

TCChenlong commented Apr 25, 2022

ImNoBadBoy left a comment

ImNoBadBoy left a comment

ImNoBadBoy Apr 25, 2022

ronny1996 left a comment •

edited

Loading

ronny1996 Apr 26, 2022

ronny1996 Apr 26, 2022

paddle-bot-old bot commented May 3, 2022

paddle-bot bot commented Aug 29, 2023

		@@ -1,4 +1,4 @@
		# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.
		# Copyright (c) 021 PaddlePaddle Authors. All Rights Reserved.

【Hackathon 33】Modified the case where Tensor cannot be used on DCU #41695

【Hackathon 33】Modified the case where Tensor cannot be used on DCU #41695

Conversation

ImNoBadBoy commented Apr 12, 2022 • edited Loading

PR types

PR changes

Describe

CLAassistant commented Apr 12, 2022 • edited Loading

paddle-bot-old bot commented Apr 12, 2022

paddle-bot-old bot commented Apr 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TCChenlong commented Apr 25, 2022

ImNoBadBoy left a comment

Choose a reason for hiding this comment

ImNoBadBoy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ronny1996 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paddle-bot-old bot commented May 3, 2022

paddle-bot bot commented Aug 29, 2023

ImNoBadBoy commented Apr 12, 2022 •

edited

Loading

CLAassistant commented Apr 12, 2022 •

edited

Loading

ronny1996 left a comment •

edited

Loading