Add yaml and unittest for instance_norm op #43060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
approved these changes
Jun 1, 2022
| @@ -1030,6 +1030,17 @@ | |||
| data_type : x | |||
| backward : index_select_grad | |||
|
|
|||
| - api : instance_norm | |||
| args : (Tensor x, Tensor scale, Tensor bias, float epsilon) | |||
| output : Tensor(y), Tensor(saved_mean), Tensor(saved_variance) | |||
There was a problem hiding this comment.
saved_mean和saved_variance需要配置成intermediate
| @@ -927,6 +927,29 @@ | |||
| data_type : x | |||
| no_need_buffer : x | |||
|
|
|||
| - backward_api : instance_norm_double_grad | |||
| forward : instance_norm_grad(Tensor x, Tensor fwd_scale, Tensor saved_mean, Tensor saved_variance, Tensor grad_y, float epsilon) -> Tensor(grad_x), Tensor(grad_scale), Tensor(grad_bias) | |||
| args : (Tensor x, Tensor fwd_scale, Tensor saved_mean, Tensor saved_variance, Tensor grad_y, Tensor grad_x_grad, Tensor grad_scale_grad, Tensor grad_bias_grad, float epsilon) | |||
There was a problem hiding this comment.
fwd_scale这个命名方式在yaml配置里有些奇怪，可以直接用scale吗？
There was a problem hiding this comment.
不能，使用scale有编译问题，反向yaml自动生成代码还需要继续优化，报错经常和名字有关，配置yaml不方便
| @@ -1404,7 +1404,7 @@ def GenerateNodeDefinition(self, next_grad_node_creation_str, | |||
| const auto& out_metas = OutputMeta(); | |||
| paddle::small_vector<std::vector<paddle::experimental::Tensor>, egr::kSlotSmallVectorSize> returns({slot_num_bwd_outputs}); | |||
| for (int i = 0; i < {slot_num_bwd_outputs}; ++i) {{ | |||
| returns[i].resize(out_metas[i].size()); | |||
| out_metas[i].size() == 0 ? returns[i].resize(1) : returns[i].resize(out_metas[i].size()); | |||
There was a problem hiding this comment.
是的，输入是optional，且不需要计算其梯度的时候生成的代码有问题，会出segmentfault
fuyou765
pushed a commit
to fuyou765/Paddle
that referenced
this pull request
Jun 7, 2022
* add yaml * fix infrt compile bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
为Instance norm添加新动态图使用的前反向yaml及单测。