Remove tests with save_quant_model.py #50307
Merged
+13
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@wozna Could you please review? |
wozna
reviewed
Feb 8, 2023
| @@ -441,28 +415,7 @@ if(LINUX AND WITH_MKLDNN) | |||
| set(QUANT2_LSTM_OPS_TO_QUANTIZE "fusion_lstm") | |||
There was a problem hiding this comment.
I think this var is no longer used.
| save_quant_nlp_model_test( | ||
| save_quant2_model_gru ${QUANT2_GRU_MODEL_DIR}/GRU_quant_acc | ||
| ${QUANT2_INT8_GRU_SAVE_PATH} ${QUANT2_GRU_OPS_TO_QUANTIZE}) | ||
|
|
||
| set(QUANT2_INT8_LSTM_SAVE_PATH "${QUANT_INSTALL_DIR}/lstm_quant2_int8") |
There was a problem hiding this comment.
Maybe you can move this line closer where is used to line 432.
|
@kolinwei @XieYunshen could you please review and approve PR-CI-Coverage? |
|
你的PR已合入Paddle库，请关注后续测试结果。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Remove tests with save_quant_model.py from PaddlePaddle.
There is still a lot of testing with save_quant_model.py. We want this to be thrown out as it's not further supported anyway and will stop working over time.