Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] add dgc jemalloc third_party cache #54392

Merged
merged 20 commits into from
Jun 26, 2023

Conversation

sanbuphy
Copy link
Contributor

@sanbuphy sanbuphy commented Jun 6, 2023

PR types

Others

PR changes

Others

Description

#54305

@paddle-bot
Copy link

paddle-bot bot commented Jun 6, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 6, 2023
@sanbuphy sanbuphy changed the title add dgc jemalloc third_party cache [cmake] add dgc jemalloc third_party cache Jun 6, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 7, 2023
risemeup1
risemeup1 previously approved these changes Jun 9, 2023
Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,这个PR真不容易

@sanbuphy
Copy link
Contributor Author

sanbuphy commented Jun 9, 2023

LGTM,这个PR真不容易

确实 眼泪流下来😂

@risemeup1
Copy link
Contributor

LGTM,这个PR真不容易

确实 眼泪流下来😂

兄弟,你的codestyle没过,pre-commit解决一下吧啊

@sanbuphy
Copy link
Contributor Author

LGTM,这个PR真不容易

确实 眼泪流下来😂

兄弟,你的codestyle没过,pre-commit解决一下吧啊

pre-commit了 但是挂CI /(ㄒoㄒ)/~~

@sanbuphy sanbuphy requested a review from risemeup1 June 14, 2023 03:54
@sanbuphy
Copy link
Contributor Author

LGTM,这个PR真不容易

确实 眼泪流下来joy

兄弟,你的codestyle没过,pre-commit解决一下吧啊

应该可以和入了

Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit 34cfbe7 into PaddlePaddle:develop Jun 26, 2023
@sanbuphy sanbuphy deleted the third_other branch June 26, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants