Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改COPY-FROM No. 3 autograd #54921

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jun 27, 2023

PR types

Others

PR changes

Others

Description

修改COPY-FROM No. 3 autograd

@paddle-bot
Copy link

paddle-bot bot commented Jun 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@gouzil
Copy link
Member Author

gouzil commented Jun 27, 2023

@sunzhongkai588

@paddle-bot paddle-bot bot added the contributor External developers label Jun 27, 2023
@luotao1 luotao1 self-assigned this Jun 28, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 28, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 PR 不要加 test=document_fix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是因为加了 test=document_fix 导致这边没有编译新的 wheel 包,进而 COPY 不过去,新提一个空的 commit 触发这边 build CI,之后重新触发 docs CI 试试

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge 的应该也算吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该算吧

sunzhongkai588
sunzhongkai588 previously approved these changes Jul 5, 2023
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-07-03 23:49:22 ----------------End of the Check--------------------
2023-07-03 23:49:22 In addition, mistakes found in sample codes: samplecode_temp/paddle.autograd.PyLayer_example.py
2023-07-03 23:49:22 1 sample codes ran success
2023-07-03 23:49:22 1 sample codes ran failed
2023-07-03 23:49:22 samplecode_temp/paddle.autograd.PyLayer_example.py
2023-07-03 23:49:22 Mistakes found in sample codes. Please recheck the sample codes.'
2023-07-03 23:49:22 

示例代码单测失败

@sunzhongkai588
Copy link
Contributor

2023-07-03 23:49:22 ----------------End of the Check--------------------
2023-07-03 23:49:22 In addition, mistakes found in sample codes: samplecode_temp/paddle.autograd.PyLayer_example.py
2023-07-03 23:49:22 1 sample codes ran success
2023-07-03 23:49:22 1 sample codes ran failed
2023-07-03 23:49:22 samplecode_temp/paddle.autograd.PyLayer_example.py
2023-07-03 23:49:22 Mistakes found in sample codes. Please recheck the sample codes.'
2023-07-03 23:49:22 

示例代码单测失败

@wanghuancoder 辛苦review一下,因为代码是从docs下的中文文档原封不动迁移过来的。
PyLayerContext: https://github.com/PaddlePaddle/docs/blob/develop/docs/api/paddle/autograd/PyLayerContext_cn.rst
PyLayer :https://github.com/PaddlePaddle/docs/blob/develop/docs/api/paddle/autograd/PyLayer_cn.rst


data = paddle.randn([2, 3], dtype="float64")
data.stop_gradient = False
z = cus_tanh.apply(data, func1=paddle.tanh)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

示例报错,把如下代码删掉吧:
, func1=paddle.tanh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit d6e259b into PaddlePaddle:develop Jul 6, 2023
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
* [autograd] add copy-from; test=document_fix

* [autograd] add copy-from; test=document_fix

* fix
@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
@gouzil gouzil deleted the doc_add_autograd_copy_from branch September 24, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants