Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix_ir_printer #54927

Merged
merged 2 commits into from
Jul 3, 2023
Merged

fix_ir_printer #54927

merged 2 commits into from
Jul 3, 2023

Conversation

xingmingyyj
Copy link
Contributor

@xingmingyyj xingmingyyj commented Jun 28, 2023 •
edited by kangguangli
Loading

PR types

Others

PR changes

Others

Description

在IrPrinter::PrintProgram函数中调用PrintRegion函数,修改PrintAttribute参数
解决了 #54499 的TODO。

@paddle-bot
Copy link

paddle-bot bot commented Jun 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 28, 2023
@paddle-bot
Copy link

paddle-bot bot commented Jun 28, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@kangguangli kangguangli self-requested a review June 28, 2023 09:46
@kangguangli kangguangli requested a review from winter-wang June 30, 2023 09:08
@kangguangli kangguangli assigned yuanlehome and unassigned yuanlehome Jun 30, 2023
@kangguangli kangguangli requested a review from yuanlehome June 30, 2023 09:09
kangguangli
kangguangli approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@kangguangli kangguangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yuanlehome
yuanlehome approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@yuanlehome yuanlehome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangguangli kangguangli merged commit 485c515 into PaddlePaddle:develop Jul 3, 2023
@luotao1
Copy link
Contributor

luotao1 commented Jul 6, 2023

hi, @xingmingyyj

  • 非常感谢你对飞桨框架的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangguangli kangguangli kangguangli approved these changes

@yuanlehome yuanlehome yuanlehome approved these changes

@winter-wang winter-wang Awaiting requested review from winter-wang

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xingmingyyj @CLAassistant @luotao1 @kangguangli @yuanlehome