Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xdoctest][task 105]reformat example code with google style in python/paddle/optimizer/adamax.py #56167

Merged
merged 3 commits into from
Aug 11, 2023
Merged

[xdoctest][task 105]reformat example code with google style in python/paddle/optimizer/adamax.py #56167

merged 3 commits into from
Aug 11, 2023

Conversation

Candy2Tang
Copy link
Contributor

@Candy2Tang Candy2Tang commented Aug 10, 2023 •
edited
Loading

PR types

Others

PR changes

Docs

Description

  • 按照规范优化了adamax的示例代码
  • 顺手修复了几个英文词的拼写错误

对应tracking issue: #55629
预览链接：

Plus：

  • convert-doctest 很好用
  • 下面这个本地测试命令也很用
xdoctest \
  --debug --options "+IGNORE_WHITESPACE" --style "freeform" \
  --global-exec "import paddle\npaddle.device.set_device('cpu')" \
  xdoctest_test

@paddle-bot
Copy link

paddle-bot bot commented Aug 10, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 10, 2023
SigureMo
SigureMo reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点点格式上的建议～

其他看起来没啥问题，等 CI 看看过没过～

python/paddle/optimizer/adamax.py Outdated Show resolved Hide resolved
python/paddle/optimizer/adamax.py Outdated Show resolved Hide resolved
@SigureMo
Copy link
Member

另外提一些使用 GitHub 的小建议，可以在本 PR 里链上 tracking issue #55629，这样那边是会显示被这边链上的，review 起来会方便些

以及最好加一下预览链接，方便 review 时参考

相关内容可以复用模板

image

当然不是说描述里不能写其他内容啦，只要该有的都有，就随便写～

@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Aug 11, 2023
SigureMo
SigureMo approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit 9e6f443 into PaddlePaddle:develop Aug 11, 2023
@luotao1 luotao1 mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Candy2Tang @SigureMo @luotao1 @sunzhongkai588