Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xdoctest][task 237] reformat example code with google style in python/paddle/distributed/utils/moe_utils.py #57202

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[xdoctest][task 237] reformat example code with google style in python/paddle/distributed/utils/moe_utils.py #57202

merged 2 commits into from
Sep 12, 2023

Conversation

jinyouzhi
Copy link
Contributor

@paddle-bot
Copy link

paddle-bot bot commented Sep 11, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 11, 2023
SigureMo
SigureMo reviewed Sep 12, 2023
View reviewed changes
python/paddle/distributed/utils/moe_utils.py Outdated Show resolved Hide resolved
python/paddle/distributed/utils/moe_utils.py Outdated Show resolved Hide resolved
python/paddle/distributed/utils/moe_utils.py Outdated Show resolved Hide resolved
python/paddle/distributed/utils/moe_utils.py Outdated Show resolved Hide resolved
python/paddle/distributed/utils/moe_utils.py Outdated Show resolved Hide resolved
python/paddle/distributed/utils/moe_utils.py Outdated Show resolved Hide resolved
@jinyouzhi
Copy link
Contributor Author

image

我这有个问题，为什么moe_utils这个包必需先from paddle.distributed.utils import moe_utils进来才能调到，而其他几个不用。

@SigureMo
Copy link
Member

我这有个问题，为什么moe_utils这个包必需先from paddle.distributed.utils import moe_utils进来才能调到，而其他几个不用。

image

可能其它几个在 import paddle 的时候就已经被其他地方 import 过了吧

SigureMo
SigureMo approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Sep 12, 2023
@luotao1 luotao1 merged commit 6d936f9 into PaddlePaddle:develop Sep 12, 2023
@luotao1 luotao1 mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinyouzhi @SigureMo @luotao1