[Docathon] Fix en api_label #57711
Merged
[Docathon] Fix en api_label #57711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
sunzhongkai588
approved these changes
Sep 26, 2023
| @@ -237,7 +237,7 @@ def googlenet(pretrained=False, **kwargs): | |||
| Args: | |||
| pretrained (bool, optional): Whether to load pre-trained weights. If True, returns a model pre-trained | |||
| on ImageNet. Default: False. | |||
| **kwargs (optional): Additional keyword arguments. For details, please refer to :ref:`GoogLeNet <api_paddle_vision_GoogLeNet>`. | |||
| **kwargs (optional): Additional keyword arguments. For details, please refer to :ref:`GoogLeNet <api_paddle_vision_models_GoogLeNet>`. | |||
There was a problem hiding this comment.
发现了一个问题，ref <api_label> 的时候，api_label是大小写不敏感的？比如 googlenet 这边引用 GoogLeNet，但最后官网生成的引用链接是 .../vision/models/googlenet_en.html#api-paddle-vision-models-googlenet 而不是 .../vision/models/GoogLeNet_en.html @SigureMo
There was a problem hiding this comment.
这样的话，可能需要对重名的其中一个进行修改了
英文 label 生成见：
这个比较类似文件大小写不敏感系统导致的重名问题，可以尝试一个类似的解决方案
中文可能需要同样的解决方案
或许和中文文件名一样使用 _upper 后缀即可，这样甚至中文那边逻辑不需要对 _upper 特判了
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* fix en api_label * fix summary
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* fix en api_label * fix summary
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix en api_label * fix summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
修复英文文档中 ref 引用的api_label
- :ref:`[^a]，例如 #57704
- 含有标签的引用
Related links：
#57363
@sunzhongkai588 @SigureMo