Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Some Lower in AutoTune Unit Tests #58146

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

zhhsplendid
Copy link
Member

@zhhsplendid zhhsplendid commented Oct 17, 2023

PR types

Others

PR changes

Others

Description

pcard-75206
Replace Some Lower in AutoTune Unit Tests

@paddle-bot
Copy link

paddle-bot bot commented Oct 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhhsplendid zhhsplendid changed the title Replace some Lower in unit test Replace Some Lower in AutoTune Unit Tests Oct 17, 2023

LOG(INFO) << "fn:\n" << fn;

auto tensors =
CollectIRNodes(fn, [](const Expr* x) { return x->as_tensor(); });
ASSERT_EQ(tensors.size(), 5UL);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the number of tensors decrease here?
It looks like there should be 3 here, but why did the old version have 5 tensors?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前Lower/Ast生成的tensor,会含有计算body,但这个其实我们Lower之后用不着了。

因为计算的tensor在我现在Lower/Ast没了,所以那里改成3了

Copy link
Contributor

@BiynXu BiynXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit b1fc0ee into PaddlePaddle:develop Oct 19, 2023
hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Replace Some Lower in AutoTune Unit Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants