【PaddlePaddle Hackathon 5 No.48】Fix bug that thread configuration parameters are out of bounds #58307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@luotao1 涛姐这个PR改动超千行了，麻烦通过一下~~ |
|
@wanghuancoder 您提到的 |
|
Sorry to inform you that dc039bd's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
luotao1
changed the title
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…ameters are out of bounds (PaddlePaddle#58307) * modified: paddle/phi/kernels/gpu/strided_copy_kernel.cu * modified: VerifyThreadConfigurationParameters * fix bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Description
StridedCopyKernel在某些情况下，block.x、block.y、block.z、grid.y、grid.z的数值，会变的极端：过大，会报错；过小，性能会受到影响。
硬件限制
block.x <= 1024
block.y <= 1024
block.z <= 64
block.x * block.y * block.z >= 96（小于96时性能大幅降低）
block.x * block.y * block.z <= 1024
grid.x 无限制
grid.y < 2^16
grid.z < 2^16
关联PR
【PaddlePaddle Hackathon 5 No.48】ContiguousKernel、StridedCopyKernel算子CPU、GPU性能优化 -part #57835