[XPU] plain softmax_mask_fuse_upper_triangle implement #58346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
LGTM |
|
您的邮件已收到，我将尽快回信。谢谢您！Your email has been received and I will reply as soon as possible. Thank you！
|
QingshuChen
approved these changes
Oct 25, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
在
flash_attention.py里面，会根据不同的设备，以及不同的head_dim执行不同的操作。目前XPU下面没有flash attention的实现，会走普通的计算路径。但是同时也没有
softmax_mask_fuse_upper_triangle的实现，因此会报错。本PR先简单“垫”了一下，用普通的“先生成mask再做softmax”的方式来进行计算，至少不会让训练挂掉。
其中
get_triangle_upper_mask函数的灵感来源于PaddleNLP中的GPT-3模型。