Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(cinn): update cinn ci to support dynamic shape #58996

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

6clc
Copy link
Contributor

@6clc 6clc commented Nov 14, 2023

PR types

Others

PR changes

Others

Description

Pcard-72384

cinn only tests use cinn wheel from paddle with cinn

Copy link

paddle-bot bot commented Nov 14, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link

paddle-bot bot commented Nov 14, 2023

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@6clc 6clc force-pushed the ci_dyn branch 4 times, most recently from 8252274 to 180fdbb Compare November 21, 2023 07:08
@6clc 6clc force-pushed the ci_dyn branch 2 times, most recently from 49af739 to 83a823d Compare November 26, 2023 15:16
target_link_libraries(cinnapi op_dialect_vjp phi)
add_dependencies(cinnapi op_dialect_vjp phi)
target_link_libraries(cinnapi op_dialect phi)
add_dependencies(cinnapi op_dialect phi)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请问,这里从 op_dialect_vjp -> op_dialect 的原因是什么呀?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cinn依赖op_dialect_vjp的话,paddle with cinn编译的cinn only wheel包和paddle wheel共同使用unused_var_check 冲突。windows平台op_dialect_vjp解依赖unused_var_check 还有一些工作量。 cinn还在接pir的开始阶段,暂时只依赖op_dialect。等解完依赖会再改回来。

Comment on lines +125 to +127
#endif

#ifndef PADDLE_WITH_CUDA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#endif
#ifndef PADDLE_WITH_CUDA
#else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我会在下个pr中升级cinn jit isnstruction支持动态shape中修改。

Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzSean ZzSean merged commit 9ffb77a into PaddlePaddle:develop Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants