-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add type promotion for complex and real number. #61163
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry to inform you that 9b1caf1's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
jeff41404
reviewed
Apr 8, 2024
jeff41404
reviewed
Apr 8, 2024
jeff41404
reviewed
Apr 8, 2024
jeff41404
reviewed
Apr 8, 2024
jeff41404
reviewed
Apr 8, 2024
jeff41404
reviewed
Apr 8, 2024
the description above is too brief, it's better to introduce the rules for our type promotion |
jeff41404
previously approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zxcd
force-pushed
the
type_promotion_stage2_T_T
branch
from
April 24, 2024 12:34
de8ac06
to
71fd732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
New features
Description
card-78750
As there were unreasonable type promotion in Paddle, which the previous logic was aligned to the left tensor, like:
This behavior will be fixed more in line with mathematical logic, like:
Furthermore, after discussion, we will limit the behavior of automatic type promotion to floating-point numbers, and between real and complex numbers in Tensor and Tensor. Tensor and Scalar will still support all dtypes.
Those PR #60638 , #59518 fixed the behavior in few APIs between floating-point numbers in Tensor and Tensor.
This PR will support all binary operation API, and type promotion between real and complex numbers in Tensor and Tensor. Also the behavior between Tensor and Scalar will be corrected.