Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] fix _wget_download security problem #61287

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[Security] fix _wget_download security problem #61287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/paddle/utils/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import hashlib
import os
import os.path as osp
import shlex
import shutil
import subprocess
import sys
Expand Down Expand Up @@ -204,7 +205,8 @@ def _wget_download(url: str, fullname: str):
'https',
), 'Only support https and http url'
# using wget to download url
tmp_fullname = fullname + "_tmp"
tmp_fullname = shlex.quote(fullname + "_tmp")
url = shlex.quote(url)
# –user-agent
command = f'wget -O {tmp_fullname} -t {DOWNLOAD_RETRY_LIMIT} {url}'
subprc = subprocess.Popen(
Expand Down