Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup][C-17] clean some random_seed for test #61504

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Feb 2, 2024

PR types

Others

PR changes

Others

Description

link #61385
替代 Program.random_seed

  • test_sync_batch_norm_op 未替换
    @gouzil

@SigureMo
Copy link
Member

SigureMo commented Feb 2, 2024

2024-02-02 23:41:03  x: array([[[[-1.944877e+00,  4.711076e-01,  2.370782e+00, ...,
2024-02-02 23:41:03            4.483875e-01, -4.405729e-01,  8.522653e-01],
2024-02-02 23:41:03          [-2.374060e+00,  8.557144e-01,  1.507929e+00, ...,...
2024-02-02 23:41:03  y: array([[[[ 1.892567e+00, -5.225285e-01,  2.749850e+00, ...,
2024-02-02 23:41:03           -1.442565e+00,  3.851413e-02,  3.485787e+00],
2024-02-02 23:41:03          [-5.042827e+00, -2.698780e+00, -2.226312e-01, ...,...
2024-02-02 23:41:03 
2024-02-02 23:41:03 ----------------------------------------------------------------------
2024-02-02 23:41:03 Ran 10 tests in 73.553s
2024-02-02 23:41:03 
2024-02-02 23:41:03 FAILED (failures=4, skipped=2)
2024-02-02 23:41:03 
2024-02-02 23:41:03 
2024-02-02 23:41:03 
2024-02-02 23:41:03 0% tests passed, 1 tests failed out of 1
2024-02-02 23:41:03 
2024-02-02 23:41:03 Label Time Summary:
2024-02-02 23:41:03 RUN_TYPE=DIST    =  79.86 sec*proc (1 test)
2024-02-02 23:41:03 
2024-02-02 23:41:03 Total Test time (real) =  80.01 sec
2024-02-02 23:41:03 
2024-02-02 23:41:03 The following tests FAILED:
2024-02-02 23:41:03 	2338 - test_sync_batch_norm_op_static_build (Failed)

test_sync_batch_norm_op 看来也是有问题的,这个 PR 暂时 revert,@gouzil 可以记录下问题

@paddle-bot paddle-bot bot added the contributor External developers label Feb 2, 2024
@SigureMo
Copy link
Member

SigureMo commented Feb 2, 2024

啊,另一个没改这个单测的 PR test_sync_batch_norm_op_static_build 也挂了,我先 rerun 观察一下效果

@SigureMo SigureMo added the HappyOpenSource 快乐开源活动issue与PR label Feb 2, 2024
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Feb 3, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Feb 3, 2024
@SigureMo
Copy link
Member

SigureMo commented Feb 3, 2024

test_sync_batch_norm_op 看起来确实不太行,这个 PR revert 吧

@ooooo-create
Copy link
Contributor Author

test_sync_batch_norm_op 看起来确实不太行,这个 PR revert 吧

done~

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit d6ccece into PaddlePaddle:develop Feb 5, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants