Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup][B-2] clean some paddle.base.dygraph.to_variable for test #61904

Merged
merged 11 commits into from
Feb 23, 2024
Merged

[Cleanup][B-2] clean some paddle.base.dygraph.to_variable for test #61904

merged 11 commits into from
Feb 23, 2024

Conversation

PommesPeter
Copy link
Contributor

PR types

Others

PR changes

Others

Description

#61385

@PommesPeter PommesPeter changed the title [Cleanup][B-1] clean some paddle.base.dygraph.to_variable for test [Cleanup][B-2] clean some paddle.base.dygraph.to_variable for test Feb 21, 2024
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Feb 21, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Feb 21, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Feb 21, 2024
@SigureMo
Copy link
Member

另外麻烦一起删一下 test_basic_api_transformation 里无用的 self.place = (...)，感谢～

@PommesPeter
Copy link
Contributor Author

另外麻烦一起删一下 test_basic_api_transformation 里无用的 self.place = (...)，感谢～

好嘞~

@SigureMo SigureMo mentioned this pull request Feb 21, 2024
Merged
gouzil
gouzil previously approved these changes Feb 22, 2024
View reviewed changes
@PommesPeter
Copy link
Contributor Author

CINN CI 出现了精度问题貌似没看到具体的问题

@SigureMo
Copy link
Member

CINN CI 出现了精度问题貌似没看到具体的问题

rerun 了

SigureMo
SigureMo approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit d316845 into PaddlePaddle:develop Feb 23, 2024
30 checks passed
@gouzil gouzil mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

@gouzil gouzil gouzil left review comments

Assignees

@luotao1 luotao1

@SigureMo SigureMo

@gouzil gouzil

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PommesPeter @SigureMo @gouzil @luotao1