[CINN] Refact struct group #62339
Merged
[CINN] Refact struct group #62339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
|
|
|
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
zyfncg
reviewed
Mar 4, 2024
| @@ -86,6 +86,15 @@ inline OpLowerer<pir::GroupPtr> CreateOpLowerer(const Target& target) { | |||
| auto* impl_base = new pir::OpLowererImpl(target); | |||
| return OpLowerer<pir::GroupPtr>(impl_base); | |||
| } | |||
|
|
|||
Comment on lines
287
to
288
| using GroupPtr = std::shared_ptr<Group>; | ||
| GroupPtr base_group; |
There was a problem hiding this comment.
不需要持有原来的Group，需要的成员直接拷贝过来，这个class可以单独放到一个新文件中
ZelinMa557
force-pushed
the
refact-group
branch
8 times, most recently
from
5f663f5 to
8f2a4f3
Compare
28 tasks
tc20042008
reviewed
Mar 8, 2024
BiynXu
reviewed
Mar 8, 2024
ZelinMa557
force-pushed
the
refact-group
branch
8 times, most recently
from
6fa8c68 to
1dccb6f
Compare
ZelinMa557
force-pushed
the
refact-group
branch
from
1dccb6f to
e7a7d74
Compare
zyfncg
previously approved these changes
Mar 19, 2024
ZelinMa557
force-pushed
the
refact-group
branch
2 times, most recently
from
46d0fac to
bf1f14f
Compare
…_op_pass Signed-off-by: ZelinMa557 <3388706467@qq.com>
ZelinMa557
force-pushed
the
refact-group
branch
from
bf1f14f to
517aa25
Compare
Aurelius84
approved these changes
Mar 25, 2024
zyfncg
approved these changes
Mar 25, 2024
tc20042008
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Replace struct
GroupwithOpLoweringGroupin the lower_cinn_fusion_op_pass.