【Hackathon 6th No.6】为 Paddle 新增 StudentT API -part #64294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
xuxinyi389
reviewed
May 17, 2024
| sample_mean = samples.mean(axis=0) | ||
| sample_variance = samples.var(axis=0) | ||
|
|
||
| np.testing.assert_allclose( |
There was a problem hiding this comment.
There was a problem hiding this comment.
这个经验值要在rfc同步更新，并将由来说清楚
There was a problem hiding this comment.
xuxinyi389
reviewed
May 17, 2024
| ) | ||
| var = paddle.where( | ||
| nan_index, paddle.full_like(var, fill_value=float('nan')), var | ||
| ) |
There was a problem hiding this comment.
任何情况下，此处两个paddle.where op都会进行判断执行。一般而言对于判断分支需要将概率最大的分支放在最前面，即df在1和2之间概率应该默认是最频繁的场景，调整下写法。此外命名nan_index是不是有点怪，中文名“nan索引”，但其实际是作为paddle.where的condition参数
|
LGTM |
|
Sorry to inform you that 82e7413's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
| * :math:`scale = \sigma`: is the scale parameter. | ||
| * :math:`\Gamma(\cdot)`: is the gamma function. | ||
|
|
||
| Args: |
luotao1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
新增 StudentT 分布类
rfc: https://github.com/PaddlePaddle/community/blob/master/rfcs/APIs/20240428_api_design_for_StudentT.md