Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prim][CINN] Support decomp of clip and fix overflow in CINN codegen #64529

Merged
merged 38 commits into from
May 27, 2024
Merged

[Prim][CINN] Support decomp of clip and fix overflow in CINN codegen #64529

merged 38 commits into from
May 27, 2024

Conversation

cyber-pioneer
Copy link
Contributor

@cyber-pioneer cyber-pioneer commented May 22, 2024 •
edited
Loading

PR Category

Others

PR Types

Others

Description

Pcard-66975
Support decom rule of clip.
Fix float overflow in cude codegen in CINN.
Add flag FLAGS_cinn_custom_code_path to debug cude codegen in CINN:

  1. FLAGS_cinn_source_code_save_path="source_code.cu" python test_xxx.py
  2. debug source_code.cu
  3. FLAGS_cinn_custom_code_path="path to source_code.cu" python test_xxx.py

Eddie-Wang1120 and others added 27 commits May 2, 2024 14:24
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented May 22, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@cyber-pioneer cyber-pioneer changed the title Debug clip3 [Prim][CINN] Support decomp of clip May 24, 2024
@cyber-pioneer cyber-pioneer changed the title [Prim][CINN] Support decomp of clip [Prim][CINN] Support decomp of clip and fix overflow in CINN codegen May 24, 2024
tc20042008
tc20042008 reviewed May 24, 2024
View reviewed changes
paddle/cinn/ir/ir_printer.cc Outdated Show resolved Hide resolved
paddle/cinn/backends/compiler.cc Outdated Show resolved Hide resolved
paddle/cinn/ir/ir_printer.cc Outdated Show resolved Hide resolved
paddle/cinn/runtime/flags.cc Outdated Show resolved Hide resolved
tc20042008
tc20042008 reviewed May 24, 2024
View reviewed changes
paddle/cinn/backends/compiler.cc Outdated Show resolved Hide resolved
paddle/cinn/backends/compiler.cc Outdated Show resolved Hide resolved
paddle/cinn/ir/ir_printer.cc Outdated Show resolved Hide resolved
Aurelius84
Aurelius84 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paddle/cinn/backends/compiler.cc
std::ifstream file(path);

if (!file.is_open()) {
std::cerr << "Unable to open file: " << path << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里建议后续改为PADDLE_THROW

@Aurelius84 Aurelius84 merged commit 4338201 into PaddlePaddle:develop May 27, 2024
32 checks passed
@Eddie-Wang1120 Eddie-Wang1120 mentioned this pull request May 29, 2024
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tc20042008 tc20042008 tc20042008 left review comments

@6clc 6clc 6clc left review comments

@Aurelius84 Aurelius84 Aurelius84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyber-pioneer @Aurelius84 @6clc @tc20042008 @Eddie-Wang1120