Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][Typos][A-[38-40]] Fix typo (astroid，attemps，attribtes) #69558

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[CodeStyle][Typos][A-[38-40]] Fix typo (astroid，attemps，attribtes) #69558

merged 3 commits into from
Nov 22, 2024

Conversation

a2064968462
Copy link
Contributor

@a2064968462 a2064968462 commented Nov 20, 2024 •
edited
Loading

PR Category

User Experience

PR Types

Others

Description

Fix:
attribtes
attemps
Undo:
astroid 涉及 api 名称变动，已加入到 default.extend-words

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 20, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 20, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

mouren seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 20, 2024
@SigureMo SigureMo mentioned this pull request Nov 20, 2024
Open
@SigureMo
Copy link
Member

attribtes 涉及 函数 名称变动

不是函数不能改，而是 API 不能改，test_to_tensor_attribtes 只是测试 case 名，可以改

SigureMo
SigureMo requested changes Nov 20, 2024
View reviewed changes
tools/dockerfile/Dockerfile.develop.dtk Outdated
@@ -63,9 +63,9 @@ RUN pip3.10 install --upgrade pip setuptools wheel && \
pip3.8 install --upgrade pip setuptools wheel

# install pylint and pre-commit
RUN pip3.10 install pre-commit==2.17.0 pylint pytest astroid isort coverage qtconsole distro && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是个库名，不能动

paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

别的 PR 已经修改过了，merge 下最新 develop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

SigureMo
SigureMo requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

commit 的邮箱不对，与 GitHub 绑定的不一致，无法通过 CLA

_typos.toml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

astroid 不改了要移到上面去啊，下面的都是要改的，只要认领的任务，就一定要改配置，要么删，要么移

PR 描述更新下

paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc Outdated
Copy link
Member

@SigureMo SigureMo Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

恢复啊，merge 一下就恢复了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思，老师，git操作失误，多提交了一个pr，我git还不是很熟悉

@SigureMo
Copy link
Member

#69564 和这个的区别是？为什么同样的任务提两个 PR？

@SigureMo
Copy link
Member

commit 的邮箱不对，与 GitHub 绑定的不一致，无法通过 CLA

把这个问题处理了，不然无法合入

@SigureMo SigureMo mentioned this pull request Nov 21, 2024
Closed
@a2064968462
Copy link
Contributor Author

commit 的邮箱不对，与 GitHub 绑定的不一致，无法通过 CLA

把这个问题处理了，不然无法合入
image
image
已更改

@SigureMo
Copy link
Member

image

你的第一个 commit 仍然是之前的

自己找方法修改，比如 rebase，别问我怎么 rebase，自己查

@a2064968462
Copy link
Contributor Author

image 你的第一个 commit 仍然是之前的

自己找方法修改，比如 rebase，别问我怎么 rebase，自己查

好的好的，麻烦老师了

@SigureMo SigureMo mentioned this pull request Nov 21, 2024
Merged
SigureMo
SigureMo approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit 9b4e958 into PaddlePaddle:develop Nov 22, 2024
27 of 28 checks passed
This was referenced Nov 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a2064968462 @CLAassistant @SigureMo @luotao1