Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][Typos][A-36] Fix typo (assigendassined) #69655

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mikemikimike
Copy link

@mikemikimike mikemikimike commented Nov 23, 2024

PR Category

User Experience

PR Types

Devs

Description

Fix:

  • assigned

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mikemikimike
❌ strayscat
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

paddle-bot bot commented Nov 23, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo changed the title [CodeStyle][Typos][A-36] Fix typo(assigend、assined) [CodeStyle][Typos][A-36] Fix typo (assigendassined) Nov 23, 2024
SigureMo
SigureMo previously approved these changes Nov 23, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo
Copy link
Member

麻烦签署下 CLA

@SigureMo
Copy link
Member

PR 模板从哪 copy 的,完全不对,CI 过不了的

@mikemikimike
Copy link
Author

PR 模板从哪 copy 的,完全不对,CI 过不了的

@mikemikimike
Copy link
Author

PR 模板从哪 copy 的,完全不对,CI 过不了的

image
emmm已更正

@SigureMo
Copy link
Member

签一下 CLA 就能 merge 了

@mikemikimike
Copy link
Author

Snipaste_2024-11-24_19-58-02
Snipaste_2024-11-24_19-58-20
已签署

@SigureMo SigureMo closed this Nov 24, 2024
@SigureMo SigureMo reopened this Nov 24, 2024
@paddle-bot paddle-bot bot added the contributor External developers label Nov 24, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 25, 2024
@luotao1
Copy link
Contributor

luotao1 commented Nov 25, 2024

冲突了

@mikemikimike
Copy link
Author

已处理,应该是合并顺序导致的

@SigureMo
Copy link
Member

image

这个 commit 是没有签署 CLA 的

可以考虑 rebase 修改之前 commit

_typos.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants