[CINN][Add Backend Pass Comment No.5] Add comment for ir_simplify #70453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
paddle/cinn/optim/ir_simplify.h
Outdated
Comment on lines
112
to
117
| * 2. Type mismatch: | ||
| * Input IR: | ||
| * Cast<float>(5) | ||
| * Output IR: | ||
| * Cast<float>(5) (remains unchanged) | ||
| */ |
paddle/cinn/optim/ir_simplify.h
Outdated
Comment on lines
137
to
140
| * Input IR: | ||
| * for (int i = 1; i < 2; ++i) { ... } | ||
| * Output IR: | ||
| * ... |
74 tasks
liuruyan
reviewed
Dec 30, 2024
paddle/cinn/optim/ir_simplify.h
Outdated
| * Input IR: | ||
| * Block { Block { ... } } | ||
| * Output IR: | ||
| * ... |
There was a problem hiding this comment.
例子1 是否应为：
1. Single statement block:
Input IR:
Block { Block { ... } }
Output IR:
Block { ... }
paddle/cinn/optim/ir_simplify.h
Outdated
| * Input IR: | ||
| * Block { ... } | ||
| * Output IR: | ||
| * ... |
There was a problem hiding this comment.
例子2 是否应为：
2. Nested blocks:
Input IR:
Block { Block { stmt1 }, Block { stmt2 } }
Output IR:
Block { stmt1, stmt2 }
There was a problem hiding this comment.
例子2 是否应为：
2. Nested blocks: Input IR: Block { Block { stmt1 }, Block { stmt2 } } Output IR: Block { stmt1, stmt2 }
是的，我改一下
Hongqing-work
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
为 ir_simplify Pass 添加了注释