Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compare_op reuse elemwise_op_funcs #7660

Merged
merged 3 commits into from
Jan 22, 2018
Merged

Make compare_op reuse elemwise_op_funcs #7660

merged 3 commits into from
Jan 22, 2018

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jan 18, 2018

Also, remove greater than/greater equal since they just not less than/not less equal

@reyoung reyoung requested a review from JiayiFeng January 18, 2018 09:56
@reyoung reyoung force-pushed the feature/compare_op_use_elemwise branch from 5d160d3 to 9c0b290 Compare January 19, 2018 04:29
JiayiFeng
JiayiFeng approved these changes Jan 22, 2018
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit 54a4696 into PaddlePaddle:develop Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @JiayiFeng