Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optimize_op argument from get_pserver_program method of Distributed Transpiler #7667

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Remove optimize_op argument from get_pserver_program method of Distributed Transpiler #7667

merged 1 commit into from
Jan 19, 2018

Conversation

abhinavarora
Copy link
Contributor

It seems like we do not need this parameter because we already provide the optimize ops in transpile method.

@abhinavarora abhinavarora self-assigned this Jan 18, 2018
typhoonzero
typhoonzero approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@putcn putcn mentioned this pull request Jan 19, 2018
Merged
putcn added a commit that referenced this pull request Jan 19, 2018
@putcn
Merge pull request #7668 from putcn/develop
0c7111e 
doc update with #7667
@putcn putcn merged commit 7a68787 into PaddlePaddle:develop Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

@helinwang helinwang Awaiting requested review from helinwang

Assignees

@abhinavarora abhinavarora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhinavarora @typhoonzero @putcn