Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the unstable unittest #7782

Merged
merged 2 commits into from
Jan 24, 2018
Merged

Disable the unstable unittest #7782

merged 2 commits into from
Jan 24, 2018

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jan 23, 2018

Fix #7781

@reyoung reyoung requested a review from QiJune January 23, 2018 07:59
QiJune
QiJune reviewed Jan 23, 2018
View reviewed changes
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I

paddle/gserver/tests/test_LayerGrad.cpp
for (auto useGpu : {false, true}) {
testLayerGrad(config, "scale_shift", batchSize, false, useGpu, false);
}
// FIXME: Disable ScaleShiftLayer because it is not stable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to have a issue link here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

QiJune
QiJune approved these changes Jan 24, 2018
View reviewed changes
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit e6a4fac into PaddlePaddle:develop Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiJune QiJune QiJune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @QiJune