fix openblas build #7835
Merged
fix openblas build #7835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
reviewed
Jan 24, 2018
| @@ -58,7 +58,7 @@ def run_program(self): | |||
| """Run the test program. | |||
| """ | |||
| places = [core.CPUPlace()] | |||
| if core.is_compile_gpu(): | |||
There was a problem hiding this comment.
Curious how come other test pass for this line?
There was a problem hiding this comment.
shouldn't have, because my build failed at this test. not sure how yuyang's change passed.
There was a problem hiding this comment.
#7817 this is his pull
There was a problem hiding this comment.
just figured that his build didn't include this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #7834 #7836
all openblas builds fail in ci, looks like sequence2batch is built before openblas ready.
fixed by adding math_function to sequence2batch's dependency list.
also due to api change, need to update test_multihead_attention to pass CI