Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load_torch #4383

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fix load_torch #4383

merged 1 commit into from
Jan 9, 2023

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Jan 9, 2023

PR types

Bug fixes

PR changes

Others

Description

修复 load_torch

  • metadata 去重,防止重复
  • data/keyxxxxxxxFB,在特殊情况下key后面可能不会紧跟着FB。因此直接使用seek_by_string索引FB的位置。

@JunnYu JunnYu requested a review from wj-Mcat January 9, 2023 04:03
@paddle-bot
Copy link

paddle-bot bot commented Jan 9, 2023

Thanks for your contribution!

Copy link
Contributor

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #4383 (d0975b0) into develop (5a44636) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4383      +/-   ##
===========================================
- Coverage    39.71%   39.71%   -0.01%     
===========================================
  Files          432      432              
  Lines        60706    60704       -2     
===========================================
- Hits         24111    24110       -1     
+ Misses       36595    36594       -1     
Impacted Files Coverage Δ
paddlenlp/utils/serialization.py 21.09% <0.00%> (+0.32%) ⬆️
paddlenlp/utils/downloader.py 54.09% <0.00%> (-0.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JunnYu JunnYu merged commit 7304171 into PaddlePaddle:develop Jan 9, 2023
@JunnYu JunnYu deleted the update_load_torch branch January 9, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants