[unified checkpoint] Fix last checkpoint save #7810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
DrownFish19
changed the title
ZHUI
reviewed
Jan 9, 2024
paddlenlp/trainer/trainer.py
Outdated
| unified_checkpoint_config_backup = self.args.unified_checkpoint_config | ||
| # backup and remove unified_checkpoint_config for not trine stage | ||
| if not self.is_in_train: | ||
| self.args.unified_checkpoint_config = "" |
There was a problem hiding this comment.
处理完的 unified_checkpoint_config 是不是下面行形式，这里设为str，也是没问题的？
unified_checkpoint_config : ['skip_save_model_weight', 'master_weight_compatible', 'async_save']| @@ -2027,8 +2027,17 @@ def save_model(self, output_dir: Optional[str] = None, merge_tensor_parallel: Op | |||
| self.model_wrapped.get_all_parameters(convert2cpu=True) | |||
|
|
|||
| if self.args.should_save_model_state: | |||
There was a problem hiding this comment.
这里筛选了 save 的worker，不影响是不是。
我记得load的时候可能放开了这个限制。
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/2.7 #7810 +/- ##
===============================================
- Coverage 57.30% 57.30% -0.01%
===============================================
Files 584 584
Lines 87692 87708 +16
===============================================
+ Hits 50254 50260 +6
- Misses 37438 37448 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Fix last checkpoint save.