Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM] add Qwen-7B-Chat to PaddleNLP unit test #7823

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ziangqin-baidu
Copy link
Contributor

@ziangqin-baidu ziangqin-baidu commented Jan 10, 2024

PR types

add Qwen-7B-Chat in PaddleNLP unit-test (test_predictor)

PR changes

Models

Description

bug fix:

  1. fix default padding_side from right to left in batch inference of Qwen
  2. remove logits post-process in GenerationMixin > greedy_search
    unit test: add Qwen into unit test

Copy link

paddle-bot bot commented Jan 10, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9d22db) 56.96% compared to head (93cabbf) 56.96%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7823   +/-   ##
========================================
  Coverage    56.96%   56.96%           
========================================
  Files          587      587           
  Lines        88647    88645    -2     
========================================
+ Hits         50494    50496    +2     
+ Misses       38153    38149    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziangqin-baidu ziangqin-baidu force-pushed the bugfix branch 6 times, most recently from 2b55d7a to 7291212 Compare January 16, 2024 06:48
fix qwen-7b0chat model batch inference precision issue
add Qwen-7B-Chat to PaddleNLP unit test
Copy link
Contributor

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat wj-Mcat merged commit e4bd6c3 into PaddlePaddle:develop Jan 16, 2024
9 of 10 checks passed
@ziangqin-baidu ziangqin-baidu deleted the bugfix branch January 23, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants