Add Pipeline Parallel for PPO training and support generation with InferenceModel #7953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7953 +/- ##
===========================================
+ Coverage 54.29% 54.41% +0.12%
===========================================
Files 617 632 +15
Lines 96339 99476 +3137
===========================================
+ Hits 52310 54134 +1824
- Misses 44029 45342 +1313 ☔ View full report in Codecov by Sentry. |
… from main from_pratrined.
guoshengCS
changed the title
PPP 4d/support uc
Add ppo 4d test
… ppo-4d-reshard
…ain/eval to align.
|
|
gongel
reviewed
Jun 12, 2024
| # and sampling, and then broadcast to avoid broadcast logits. | ||
| if hasattr(self, "pp_group"): | ||
| paddle.distributed.broadcast( | ||
| next_tokens, src=self.pp_group.ranks[0], group=self.pp_group # use rank 0 for same seed to check |
There was a problem hiding this comment.
我看CI这里，self.pp_group有可能为None，导致.ranks[0]报错
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Add Pipeline Parallel for PPO training and support generation with InferenceModel