-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLU] Support rms_norm_mlu #8504
Conversation
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8504 +/- ##
===========================================
+ Coverage 54.39% 54.44% +0.05%
===========================================
Files 648 648
Lines 103274 103278 +4
===========================================
+ Hits 56172 56234 +62
+ Misses 47102 47044 -58 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
92fe84b
to
d385e9f
Compare
d385e9f
to
078c7ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1651,7 +1651,7 @@ def forward( | |||
is_casual = True | |||
else: | |||
is_casual = is_casual_mask(attention_mask) | |||
if get_env_device() != "npu": | |||
if get_env_device() != "npu" or get_env_device() != "mlu": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个判断疑似有问题。
PR types
New features
PR changes
Models
Description
support rms_norm_mlu