Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLU] Support rms_norm_mlu #8504

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

PeiyuLau
Copy link
Contributor

PR types

New features

PR changes

Models

Description

support rms_norm_mlu

Copy link

paddle-bot bot commented May 29, 2024

Thanks for your contribution!

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 54.44%. Comparing base (8e1f6e6) to head (078c7ce).
Report is 253 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/llama/modeling.py 28.57% 5 Missing ⚠️
paddlenlp/transformers/llama/fusion_ops.py 33.33% 2 Missing ⚠️
paddlenlp/utils/tools.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8504      +/-   ##
===========================================
+ Coverage    54.39%   54.44%   +0.05%     
===========================================
  Files          648      648              
  Lines       103274   103278       +4     
===========================================
+ Hits         56172    56234      +62     
+ Misses       47102    47044      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeiyuLau PeiyuLau force-pushed the support_rms_norm branch from 92fe84b to d385e9f Compare July 4, 2024 07:47
@DrownFish19 DrownFish19 changed the title support rms_norm_mlu [MLU] Support rms_norm_mlu Aug 23, 2024
Copy link
Collaborator

@DrownFish19 DrownFish19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit a12781f into PaddlePaddle:develop Sep 2, 2024
9 of 12 checks passed
@@ -1651,7 +1651,7 @@ def forward(
is_casual = True
else:
is_casual = is_casual_mask(attention_mask)
if get_env_device() != "npu":
if get_env_device() != "npu" or get_env_device() != "mlu":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个判断疑似有问题。

Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants