fix fast_ln backward #8719
Merged
fix fast_ln backward #8719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8719 +/- ##
===========================================
- Coverage 55.73% 55.73% -0.01%
===========================================
Files 623 623
Lines 97459 97464 +5
===========================================
+ Hits 54323 54324 +1
- Misses 43136 43140 +4 ☔ View full report in Codecov by Sentry. |
ZHUI
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
修复fast_ln反向算子的bug，保证结果诸位对齐。
原来的写法：在循环中判断is_rmsnorm，然后计算梯度，这种会导致nvcc编译的汇编代码不同，进而导致cuda算子计算精度问题。修复之后循环内保持和原来逻辑相同，通过在循环外设置mdy_local=0.f来支持rms_norm的反向计算。