[Bug fixes] Fix ring attention #8740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhangyuqin1998
force-pushed
the
fix_ringattention
branch
from
11bf3e2 to
4cd6dbc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8740 +/- ##
===========================================
- Coverage 55.73% 55.71% -0.03%
===========================================
Files 623 623
Lines 97464 97393 -71
===========================================
- Hits 54324 54259 -65
+ Misses 43140 43134 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
由于slice算子的+=运算符非inplace，导致计算出现bug，此pr进行了修复。使用下标索引替换slice算子。
修复tensor.to(dtype)引起的性能下降，替换成paddle.cast。