[AutoParallel] Refine auto_trainer save load #8767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8767 +/- ##
===========================================
- Coverage 55.43% 55.22% -0.21%
===========================================
Files 626 631 +5
Lines 98070 100091 +2021
===========================================
+ Hits 54366 55277 +911
- Misses 43704 44814 +1110 ☔ View full report in Codecov by Sentry. |
zhangbo9674
changed the title
ZHUI
reviewed
Jul 25, 2024
| self._memory_tracker.start() | ||
|
|
||
| if not self.args.enable_auto_parallel: | ||
| if not self.args.should_load_sharding_stage1_model: |
There was a problem hiding this comment.
这里先就这样吧，看后面是不是可以抽个函数出来，方便自动并行重载。
paddlenlp/trainer/auto_trainer.py
Outdated
| for p_name, p in model.state_dict().items(): | ||
| if paddle.distributed.get_rank() not in p.process_mesh.process_ids: | ||
| var_name = p.name | ||
| if ( |
There was a problem hiding this comment.
这里的一些 _moment1_0 变量，要不放到一个全局变量里面管理一下，不要hard code了
ZHUI
approved these changes
Jul 25, 2024
| @@ -216,7 +214,6 @@ def _inner_training_loop( | |||
| epochs_trained = self.state.global_step // num_update_steps_per_epoch | |||
| if not args.ignore_data_skip: | |||
| steps_trained_in_current_epoch = self.state.global_step % (num_update_steps_per_epoch) | |||
| steps_trained_in_current_epoch *= args.gradient_accumulation_steps | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Refine save load for auto_trainer.