support sft mapdataset #8840
Merged
support sft mapdataset #8840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8840 +/- ##
===========================================
- Coverage 55.44% 55.35% -0.10%
===========================================
Files 631 631
Lines 98542 98782 +240
===========================================
+ Hits 54632 54676 +44
- Misses 43910 44106 +196 ☔ View full report in Codecov by Sentry. |
gongel
reviewed
Aug 1, 2024
paddlenlp/data/indexed_dataset.py
Outdated
| @@ -68,6 +69,20 @@ def make_dataset(path, impl, skip_warmup=False): | |||
| return None | |||
|
|
|||
|
|
|||
| def make_sft_dataset(path, impl, dataclass, skip_warmup=False): | |||
There was a problem hiding this comment.
建议：make_sft_dataset(path, dataclass, skip_warmup=False, impl=“mmap”)
gongel
reviewed
Aug 1, 2024
paddlenlp/data/indexed_dataset.py
Outdated
| @@ -548,13 +574,259 @@ def exists(path): | |||
| return os.path.exists(index_file_path(path)) and os.path.exists(data_file_path(path)) | |||
|
|
|||
|
|
|||
| class SFT_MMapIndexedDataset(paddle.io.Dataset): | |||
paddlenlp/data/indexed_dataset.py
Outdated
| def make_builder(out_file, impl, save_dtype, loss_mask_file=None): | ||
| if impl == "mmap": | ||
| return MMapIndexedDatasetBuilder(out_file, dtype=save_dtype, loss_mask_file=loss_mask_file) | ||
| else: | ||
| return IndexedDatasetBuilder(out_file, dtype=save_dtype) | ||
|
|
||
|
|
||
| class SFT_MMapIndexedDatasetBuilder(object): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New Features
PR changes
Add SFTMMapIndexedDataset and SFTMMapIndexedDatasetBuilder
Description
Support offline SFT dataset.