Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZeroPadding] add greedy_zero_padding #8933

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Performance optimization

PR changes

Others

Description

Add greedy zero padding data stream.

Copy link

paddle-bot bot commented Aug 14, 2024

Thanks for your contribution!

@DesmonDay DesmonDay force-pushed the add_greedy_intokens branch from 5f47676 to ded2663 Compare August 14, 2024 09:18
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 3.00000% with 97 lines in your changes missing coverage. Please review.

Project coverage is 55.07%. Comparing base (75c7636) to head (274b881).
Report is 235 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/datasets/zero_padding_dataset.py 3.00% 97 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8933      +/-   ##
===========================================
+ Coverage    55.05%   55.07%   +0.02%     
===========================================
  Files          635      635              
  Lines        99412    99495      +83     
===========================================
+ Hits         54730    54800      +70     
- Misses       44682    44695      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DesmonDay DesmonDay force-pushed the add_greedy_intokens branch from ded2663 to 274b881 Compare August 15, 2024 12:49
Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 8599a53 into PaddlePaddle:develop Aug 19, 2024
9 of 12 checks passed
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants