move some auto_parallel args into class AutoTrainingArguments #9155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9155 +/- ##
===========================================
- Coverage 53.02% 53.02% -0.01%
===========================================
Files 656 657 +1
Lines 106153 106311 +158
===========================================
+ Hits 56288 56367 +79
- Misses 49865 49944 +79 ☔ View full report in Codecov by Sentry. |
|
Thanks for your contribution! |
ZHUI
reviewed
Sep 29, 2024
| class AutoTrainingArguments(TrainingArguments): | ||
| """ | ||
| 自动并行相关参数配置 | ||
| """ |
| @@ -61,7 +66,7 @@ def docstring_decorator(fn): | |||
|
|
|||
| @dataclass | |||
| @add_start_docstrings(TrainingArguments.__doc__) | |||
There was a problem hiding this comment.
Suggested change
| @add_start_docstrings(TrainingArguments.__doc__) | |
| @add_start_docstrings(AutoTrainingArguments.__doc__) |
可以这么换一下，看看是不是正常能够提示参数
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
给自动并行增加一个AutoTrainingArguments类，后续自动并行的相关优化开关可以放到这里面而不用每个模型都重新写一次这些优化开关的arguments，只需要写自己相关的args即可