[MoE] fix expert parallel #9760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9760 +/- ##
===========================================
- Coverage 52.70% 52.38% -0.33%
===========================================
Files 731 727 -4
Lines 117313 115146 -2167
===========================================
- Hits 61827 60316 -1511
+ Misses 55486 54830 -656 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Jan 10, 2025
| @@ -152,6 +152,9 @@ def main(): | |||
| quantization_config=quantization_config, | |||
| ) | |||
|
|
|||
| if "Qwen2Moe" in str(model_config.architectures) and training_args.data_parallel_degree > 1: | |||
| training_args.use_expert_parallel = True | |||
There was a problem hiding this comment.
不太好吧，万一用户的dp跟 expert_parallel degree对不上怎么办？
There was a problem hiding this comment.
moe layer写法就默认了是这个逻辑，expert_parallel_degree=dp_degree。觉得不好的话我把原来的逻辑改掉？
There was a problem hiding this comment.
我感觉只能默认和data_parallel_degree进行对齐，做all-to-all时是应该在数据并行组内进行
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Description
Fix MoE model using expert parallel.